Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pins on werkzeug, itsdangerous and markupsafe since they are currently not needed #2565

Merged
merged 1 commit into from
May 16, 2024

Conversation

imatiach-msft
Copy link
Contributor

Description

Removing pins on werkzeug, itsdangerous and markupsafe since they are currently not needed.
Some of these were added about a year ago to fix build breaks:
#1238
However these issues have been resolved and we should not be pinning them but instead rely on flask to pin to the correct versions unless we encounter issues again.
Otherwise, downstream customers are seeing problems with our pins being too restrictive.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@imatiach-msft
Copy link
Contributor Author

merging this for now as builds are broken due to unrelated reason, will send separate PR for broken builds (macos)

@imatiach-msft imatiach-msft merged commit 577f7a9 into main May 16, 2024
90 of 134 checks passed
@imatiach-msft imatiach-msft deleted the ilmat/unpin-werkzeug-itsdangerous-markupsafe branch May 16, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants